Conversation
This was referenced Mar 24, 2026
bmuschko
reviewed
Mar 24, 2026
Contributor
bmuschko
left a comment
There was a problem hiding this comment.
It might be worth adding some test cases for the scenarios if we don't have them yet.
Member
Author
|
Thanks yes we added those for returns in #7096 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaTemplate.apply()withcoordinates.replace()throwsIndexOutOfBoundsExceptionwhen the cursor's parent tree is not aJ.Blockand the template produces a statement (not an expression)!(parent instanceof J.Block)over-matched, routing statement templates toparseExpression()which returns an empty listJ.Return,J.Assignment,J.AssignmentOperation) that Fix JavaTemplate expression replacement inside return statements #7096 intended to handleTest plan
JavaTemplateTest8Testtests from Fix JavaTemplate expression replacement inside return statements #7096 still pass (expression replacement inside return statements)*JavaTemplate*tests pass