Fix Gradle AddDependency for matches only in test sources#6637
Merged
jkschneider merged 1 commit intomainfrom Jan 29, 2026
Merged
Fix Gradle AddDependency for matches only in test sources#6637jkschneider merged 1 commit intomainfrom
AddDependency for matches only in test sources#6637jkschneider merged 1 commit intomainfrom
Conversation
- Fix `AddDependency` scanner to only record configurations for source sets where `onlyIfUsing` actually matches, rather than all source sets in the project - Previously, when a project had both main and test sources but the type was only used in test, the dependency was incorrectly added as `implementation` instead of `testImplementation` - Root cause: `configurationsByProject` collected all source sets unconditionally, then `removeTransitiveConfigurations()` dropped `testImplementation` in favor of `implementation` - Aligns Gradle behavior with the Maven `AddDependency` which already correctly tracks scope per source set via `scopeByProject` - Add `onlyIfUsingTestScopeWithMainSource` test covering the previously broken scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddDependencyscanner to only record configurations for source sets whereonlyIfUsingactually matches, rather than all source sets in the projectimplementationinstead oftestImplementationconfigurationsByProjectcollected all source sets unconditionally, thenremoveTransitiveConfigurations()droppedtestImplementationin favor ofimplementationAddDependencywhich already correctly tracks scope per source set viascopeByProjectonlyIfUsingTestScopeWithMainSourcetest covering the previously broken scenario