Allow Kotlin method invocation type to be considered valid if null#6409
Closed
greg-dennis wants to merge 1 commit intoopenrewrite:mainfrom
Closed
Allow Kotlin method invocation type to be considered valid if null#6409greg-dennis wants to merge 1 commit intoopenrewrite:mainfrom
greg-dennis wants to merge 1 commit intoopenrewrite:mainfrom
Conversation
This was referenced Dec 11, 2025
Merged
Member
|
As discussed on openrewrite/rewrite-testing-frameworks#871 the preferred way of ignoring some type validation issues is through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This allows the type of a Kotlin
MethodInvocationto be considered valid if null, as already anticipated by the by the KotlinTreeParseVisitor.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@timtebeek has context from Slack
@Laurens-W
Have you considered any alternatives or workarounds?
I tried to find a way to force the parser to resolve the type, but the issue appears to be deep in the bowels of the Jetbrains FIR.
Any additional context
Checklist