Fix HttpSender.Response.getBody() InputStream performance and EOF handling#6381
Merged
Fix HttpSender.Response.getBody() InputStream performance and EOF handling#6381
Conversation
shanman190
approved these changes
Dec 4, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HttpSender.Response.getBody()method returns an anonymousInputStreamwrapper that only overrides the single-byteread()method. When consumers call the bulkread(byte[], int, int)method, Java's defaultInputStreamimplementation falls back to callingread()one byte at a time in a loop, resulting in extremely poor performance.Additionally, the single-byte
read()method incorrectly returns0when the body is null, but per theInputStreamcontract,-1should be returned to indicate end of stream.Solution
read(byte[] b, int off, int len)override to delegate bulk reads to the underlying stream0to-1per the InputStream contract