Return an J.Identifier instead of a MemberReference when containing is null#5614
Merged
Merged
Conversation
Laurens-W
commented
Jun 12, 2025
| qualifier.getPrefix(), | ||
| Markers.EMPTY, | ||
| JRightPadded.build(qualifier == null ? null : qualifier.withPrefix(Space.EMPTY)), | ||
| JRightPadded.build(qualifier.withPrefix(Space.EMPTY)), |
Contributor
Author
There was a problem hiding this comment.
We'd considered returning an empty identifier here but this already happens for example with this piece of JavaDoc:
/**
* {@link #n} refers to Inner
*/
so there would be no trivial way to determine whether to place the # or not, both are valid JavaDoc
J.Identifier instead of a MemberReference when containing is null
3 tasks
knutwannheden
approved these changes
Jun 12, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
When containing is null we now return an identifier instead of a MemberReference where the containing element is null
What's your motivation?
After #5535 we were seeing some
because the LST would get changed here
rewrite/rewrite-java/src/main/java/org/openrewrite/java/JavaVisitor.java
Lines 1377 to 1387 in 4c012dd
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
@jkschneider
Checklist