Merged
Conversation
Using local edge release jar
jevanlingen
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Remove feature flags around usage of Lombok, after adding local edge release jar.
What's your motivation?
Enabling Lombok by default will clear out a large number of unknown types.
Have you considered any alternatives or workarounds?
We could have flipped the feature flag to disable it if problematic, but we'd like to roll forward in the case of issues.
Any additional context
Following this change we can remove the downstream feature flags in rewrite-gradle-plugin and rewrite-logging-frameworks.