Incorporate LuaJIT-test-cleanup into the main repository#78
Closed
siddhesh wants to merge 12 commits intoopenresty:v2.1-agentzhfrom
siddhesh:luajit2-makecheck
Closed
Incorporate LuaJIT-test-cleanup into the main repository#78siddhesh wants to merge 12 commits intoopenresty:v2.1-agentzhfrom siddhesh:luajit2-makecheck
siddhesh wants to merge 12 commits intoopenresty:v2.1-agentzhfrom
siddhesh:luajit2-makecheck
Conversation
The tests and benchmarks in the LuaJIT-test-cleanup repo are more or less complete and with scaffolding added, they can now be called seamlessly from within the luajit sources using `make check` and `make bench` respectively. Since the code of LuaJIT-test-cleanup is in public domain, I have added the code in here as is with copyright notice changes. I have added a CONTRIBUTORS file to list the authors of various commits in LuaJIT-test-cleanup, bench_lua (from where the benchmark driver was taken) and LuaJIT itself to allow for a more succint copyright notice that credits authors in addition to Mike Pall in the COPYRIGHT file.
…ant. This test case reproduces the issue observed at: openresty/lua-resty-core#232 and was contributed by @lukego and myself. Co-authored-by: Luke Gorrie <lukego@gmail.com>
LuaJIT version check for lua will return true for +lua<5.2 since it does not fully implement 5.2. Move the (not package.searchers) check to +compat5.2 instead of the version check since it is implemented by compat5.2.
Fix up contents.lua to expect thread.exdata and add two more tests from c58fe79 in openresty/luajit2.
Run JIT tests only on configurations where JIT is on.
The test case assumes that the target is 64-bit because of which it fails on armv7. Drop the string comparisons and instead just do numerical comparisons to ensure that the overflowed values match on 32-bit.
This test is for LuaJIT/LuaJIT#505 Signed-off-by: s.ostanevich <s.ostanevich@sostanevich.local>
They caught a POW bug in ppc64le, so they're useful enough. We will figure out a fix if they're found to be broken.
Collaborator
Author
|
Dropping since this is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have had this patch in my tree for some time now and figure that the only way to make forward progress is to merge it into luajit2 and extend it here.
The test-cleanup repository, the t directory and the arch-specific tests form 3 different places to maintain tests and there is value in putting all of them into a single place. This patch series is the beginning for this. The patchset does the following:
testdirectory and amake checktarget.make bencht(thread.exdata smoke tests for example) intotestI'm committing to doing more in this space by merging all tests in different directories and also ensuring that all of the tests are executed whenever they're supported. There are some C++ tests for example that are not executed yet under
make check.