install openrazer-daemon script directly via setuptools#681
install openrazer-daemon script directly via setuptools#681roelvandijk wants to merge 1 commit intoopenrazer:masterfrom
Conversation
Instead of copying run_openrazer_daemon.py to $DESTDIR we can use setuptools to install scripts. This leaves the problem of the rename from run_openrazer_daemon.py to openrazer-daemon, which is solved with a Makefile target.
|
What's the advantage of doing this? |
|
The advantage is that is makes it a bit easier to package the openrazer-daemon. The packaging system only needs to use setuptools in order to install both the openrazer-daemon package and the runner script. Also makes it easier to automatically wrap the installed scripts for installation in a system-specific manner, such as replacing the See also my attempt to package OpenRazer with Nix. Still, it's just a minor difference in convenience. |
|
Also FYI @lezed1 was also working on nixos packaging, see lezed1/nixpkgs@9b9cdf6 |
|
Sorry, I really don't see an advantage except that it's complicating the makefile even more. If you just use the Makefile targets, everything you need will be installed. |
|
No problem. Thank you for reviewing! |
|
@roelvandijk I currently use Openrazer under NixOS to control all my razer devices. A few things still need to be tweaked (like getting udev to rebind devices) before I was going to PR into the main nixpkgs. Let me know if you want any help using my package set. |
|
@lezed1 Interesting! We can continue this conversation in NixOS/nixpkgs#47009 if you want. |
Instead of copying
run_openrazer_daemon.pyto$DESTDIRwe can usesetuptools to install scripts. This leaves the problem of the rename
from
run_openrazer_daemon.pytoopenrazer-daemon, which is solved witha Makefile target.