Merged
Conversation
When the internal fetch returns a qualified value, we need to extract only the "actual" value and return that to the caller. We specifically do not want to include the qualifiers in the returned value. NOTE: we cannot just have the internal fetch perform that operation for us as the server needs to retrieve the full qualified value (value plus qualifiers) when responding to a request from a client. Otherwise, the client would store the value without the qualifiers, thereby converting it to an "unqualified" value for any subsequent "get" requests. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 7e6488d)
Avoid unnecessary requests for group info from the server by passing the group info down to the members during the release from construct operation. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 201f8c1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle qualified values in client get
When the internal fetch returns a qualified value, we need
to extract only the "actual" value and return that to the
caller. We specifically do not want to include the qualifiers
in the returned value.
NOTE: we cannot just have the internal fetch perform that
operation for us as the server needs to retrieve the full
qualified value (value plus qualifiers) when responding to
a request from a client. Otherwise, the client would store
the value without the qualifiers, thereby converting it to
an "unqualified" value for any subsequent "get" requests.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 7e6488d)
Return group info to members during construct
Avoid unnecessary requests for group info from the server
by passing the group info down to the members during the
release from construct operation.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 201f8c1)