Merged
Conversation
Reset variables to NULL after free. Finalize the event library so it can clean up. Always destroy the topology because hwloc does the right thing for shmem under the covers. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit cfa4a2c)
We cannot know who else might be using the libevent library, and the libevent shutdown routine shuts down the entire library. So we have no choice but to go ahead and leak the few bytes of memory libevent holds until shutdown in the case where we truly are the only one using it. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 05590e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup inii/finalize cycle
Reset variables to NULL after free. Finalize the event
library so it can clean up. Always destroy the topology
because hwloc does the right thing for shmem under the
covers.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit cfa4a2c)
Do not shutdown libevent during finalize
We cannot know who else might be using the libevent
library, and the libevent shutdown routine shuts down
the entire library. So we have no choice but to go
ahead and leak the few bytes of memory libevent holds
until shutdown in the case where we truly are the
only one using it.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 05590e1)