Merged
Conversation
We used to have support for both Unix sockets and TCP interfaces, so we explicitly ignored all loopback devices (leaving local operations to the Unix sockets). However, at some point years back we removed the Unix socket support, transitioning solely over to TCP interfaces. Nobody remembered the TCP support ignoring loopbacks, and we always picked up public interfaces - so nobody realized the limitation. Now that we have a directive to not allow remote connections, translating into wanting a loopback device, we cannot continue to reject loopbacks. So we need to fix that bug to enable selection of the loopback. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit baea134)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to have support for both Unix sockets and TCP interfaces, so we explicitly ignored all loopback devices (leaving local operations to the Unix sockets).
However, at some point years back we removed the Unix socket support, transitioning solely over to TCP interfaces. Nobody remembered the TCP support ignoring loopbacks, and we always picked up public interfaces - so nobody realized the limitation.
Now that we have a directive to not allow remote connections, translating into wanting a loopback device, we cannot continue to reject loopbacks. So we need to fix that bug to enable selection of the loopback.
(cherry picked from commit baea134)