Switch to atomics for tracking initialization#3696
Merged
rhc54 merged 1 commit intoopenpmix:masterfrom Oct 17, 2025
Merged
Conversation
Contributor
Author
|
@hppritcha I'm getting this in the CI: Run python test/main.py -v -x test_doc
python test/main.py -v -x test_doc
shell: /usr/bin/bash -e {0}
env:
MPI4PY_TEST_SPAWN: true
pythonLocation: /opt/hostedtoolcache/Python/3.13.7/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.13.7/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.7/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.7/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.7/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.13.7/x64/lib
--------------------------------------------------------------------------
It looks like MPI_INIT failed for some reason; your parallel process is
likely to abort. There are many reasons that a parallel process can
fail during MPI_INIT; some of which are due to configuration or environment
problems. This failure appears to be an internal failure; here's some
additional information (which may only be relevant to an Open MPI
developer):
mca_pml_base_select() failed
--> Returned "Attempt to redefine an existing data type" (-31) instead of "Success" (0)Is this something new on your side?? I cannot imagine what I would have done to cause it. |
Contributor
Author
|
Looks like it is something to do with the changes in singleton init made here - just a really odd error message to result from whatever it is behind it. |
Rather than using mutex and condition variables, let's just use atomics for tracking if the library has been initialized. Remove all references to pmix_global_lock Move away from the concept of a global lock in the library. Convert all "connected" flags to atomic Avoid calling PMIx APIs from within the initialization procedures We don't want to enable API use until the library is fully initialized. Fix stop-in-init integration Fix fence_nb to handle singleton Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using mutex and condition variables, let's just use atomics for tracking if the library has been initialized, and which init entry point was used. Check for and reject attempts to call multiple mismatched entry points.
First stage in a multi-stage process.