Change to using atomic for show_help_enabled#3695
Merged
rhc54 merged 1 commit intoopenpmix:masterfrom Oct 10, 2025
Merged
Conversation
Rather than using thread locks for all things involving protection against timing. In this case, the only thing we really need is a way to know that initializaiton reached the stage where show-help is ready. So let's use an atomic to detect that we have gotten that far. We know the compiler is C11 compliant, so we don't need the "built-in" versions of the atomics, which means we also don't need to test a bunch of atomic stuff. Just check to see if the few atomic functions we need are available. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using thread locks for all things involving protection against timing. In this case, the only thing we really need is a way to know that initializaiton reached the stage where show-help is ready. So let's use an atomic to detect that we have gotten that far.
We know the compiler is C11 compliant, so we don't need the "built-in" versions of the atomics, which means we also don't need to test a bunch of atomic stuff. Just check to see if the few atomic functions we need are available.