Merged
Conversation
We were mistakenly comparing the size of the working buffer to the input size and not compressing if the working buffer was larger. However, zlib _always_ uses a larger working buffer, and so this prevented us from actually compressing. Compare the size of the resulting compressed data to the input data and don't use the compressed block if it isn't smaller - it can happen, though probably rare. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were mistakenly comparing the size of the working buffer to the input size and not compressing if the working buffer was larger. However, zlib always uses a larger working buffer, and so this prevented us from actually compressing.
Compare the size of the resulting compressed data to the input data and don't use the compressed block if it isn't smaller - it can happen, though probably rare.