Merged
Conversation
Need to preserve the procs array until completion of the upcall operation Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit fbe94bc)
Signed-off-by: Matthew Whitlock <mwhitlo@sandia.gov> (cherry picked from commit 47b6634)
Depending on tool type, we may not want to remove the tool's nspace tracker from the global list if the connection is rejected. Improve the checks for different connection scenarios. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 12918e1)
Set the default to "true" to preserve previous behavior Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit ab85e1a)
Now that tools are part of the tracked nspaces, need to be a little more careful about appending them to the trackers. Modify the toolqry example to avoid picking up system tools Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 947d75e)
The host may have registered the tool namespace, thus placing it on the global list. Detect that has happened and avoid adding a duplicate entry. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a3103b8)
Default to using the loopback interface unless remote connections are specified - in which case, reject any loopback interfaces. Provide useful show-help messages when no valid interfaces are available. If no remote connection directive is given, and no loopback interfaces are available, then accept a non-loopback interface. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit b5a5067)
A definition of MAXPATHLEN is not a mandatory part of the POSIX standard, and is not defined for hurd (where <sys/param.h> is not available). cf. https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html for further context. But it is difficult to use getcwd without MAXPATHLEN, so set a default value if it has not been defined in <sys/param.h>. This allows openpmix to build for hurd. The patch is taken from debian, https://salsa.debian.org/science-team/pmix/-/blob/e29db6a5b8e523a3b5e0d80922d5958a0d8e0d07/debian/patches/hurd-fix.patch Signed-off-by: Drew Parsons <dparsons@debian.org> (cherry picked from commit 32f1a46)
CIDs: 488049 488048 488047 487968 487020 487013 487011 457994 457993 457992 457991 456762 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 849a9c1)
Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the abort server upcall
Need to preserve the procs array until completion
of the upcall operation
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit fbe94bc)
Correctly check length in pmix_bitmap_num_set_bits
Signed-off-by: Matthew Whitlock mwhitlo@sandia.gov
(cherry picked from commit 47b6634)
Do not remove nspace from global list on rejected connection
Depending on tool type, we may not want to remove the tool's
nspace tracker from the global list if the connection is rejected.
Improve the checks for different connection scenarios.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 12918e1)
Allow foreign tools by default
Set the default to "true" to preserve previous behavior
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ab85e1a)
Cleanup a bit on connection handling
Now that tools are part of the tracked nspaces, need to be
a little more careful about appending them to the trackers.
Modify the toolqry example to avoid picking up system tools
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 947d75e)
Avoid duplicate namespace entries
The host may have registered the tool namespace, thus
placing it on the global list. Detect that has happened
and avoid adding a duplicate entry.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit a3103b8)
Improve selection of interfaces
Default to using the loopback interface unless remote connections
are specified - in which case, reject any loopback interfaces. Provide
useful show-help messages when no valid interfaces are available.
If no remote connection directive is given, and no loopback interfaces
are available, then accept a non-loopback interface.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit b5a5067)
define default MAXPATHLEN if not defined by system
A definition of MAXPATHLEN is not a mandatory part of the POSIX
standard, and is not defined for hurd (where <sys/param.h> is not
available).
cf.
https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html
for further context.
But it is difficult to use getcwd without MAXPATHLEN, so set a default
value if it has not been defined in <sys/param.h>.
This allows openpmix to build for hurd.
The patch is taken from debian,
https://salsa.debian.org/science-team/pmix/-/blob/e29db6a5b8e523a3b5e0d80922d5958a0d8e0d07/debian/patches/hurd-fix.patch
Signed-off-by: Drew Parsons dparsons@debian.org
(cherry picked from commit 32f1a46)
Silence a few Coverity complaints
CIDs:
488049
488048
488047
487968
487020
487013
487011
457994
457993
457992
457991
456762
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 849a9c1)
Update NEWS
Signed-off-by: Ralph Castain rhc@pmix.org
bot:notacherrypick