Merged
Conversation
Depending on tool type, we may not want to remove the tool's nspace tracker from the global list if the connection is rejected. Improve the checks for different connection scenarios. Signed-off-by: Ralph Castain <rhc@pmix.org>
Set the default to "true" to preserve previous behavior Signed-off-by: Ralph Castain <rhc@pmix.org>
Now that tools are part of the tracked nspaces, need to be a little more careful about appending them to the trackers. Modify the toolqry example to avoid picking up system tools Signed-off-by: Ralph Castain <rhc@pmix.org>
The host may have registered the tool namespace, thus placing it on the global list. Detect that has happened and avoid adding a duplicate entry. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not remove nspace from global list on rejected connection
Depending on tool type, we may not want to remove the tool's
nspace tracker from the global list if the connection is rejected.
Improve the checks for different connection scenarios.
Signed-off-by: Ralph Castain rhc@pmix.org
Allow foreign tools by default
Set the default to "true" to preserve previous behavior
Signed-off-by: Ralph Castain rhc@pmix.org
Cleanup a bit on connection handling
Now that tools are part of the tracked nspaces, need to be
a little more careful about appending them to the trackers.
Modify the toolqry example to avoid picking up system tools
Signed-off-by: Ralph Castain rhc@pmix.org
Avoid duplicate namespace entries
The host may have registered the tool namespace, thus
placing it on the global list. Detect that has happened
and avoid adding a duplicate entry.
Signed-off-by: Ralph Castain rhc@pmix.org