define default MAXPATHLEN if not defined by system#3672
Merged
rhc54 merged 1 commit intoopenpmix:masterfrom Sep 3, 2025
Merged
define default MAXPATHLEN if not defined by system#3672rhc54 merged 1 commit intoopenpmix:masterfrom
rhc54 merged 1 commit intoopenpmix:masterfrom
Conversation
Contributor
|
Thanks! Can you please sign off the commit? Just a line |
37cea5a to
9c2104b
Compare
Contributor
|
I'll take a gander at the CI error - nothing to do with your PR, so something else has snuck through the backdoor. |
A definition of MAXPATHLEN is not a mandatory part of the POSIX standard, and is not defined for hurd (where <sys/param.h> is not available). cf. https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html for further context. But it is difficult to use getcwd without MAXPATHLEN, so set a default value if it has not been defined in <sys/param.h>. This allows openpmix to build for hurd. The patch is taken from debian, https://salsa.debian.org/science-team/pmix/-/blob/e29db6a5b8e523a3b5e0d80922d5958a0d8e0d07/debian/patches/hurd-fix.patch Signed-off-by: Drew Parsons <dparsons@debian.org>
9c2104b to
4251cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A definition of
MAXPATHLENis not a mandatory part of the POSIX standard, and is not defined for GNU hurd operating system, where<sys/param.h>is not available.cf. https://www.gnu.org/software/hurd/community/gsoc/project_ideas/maxpath.html
for further context.
But it is difficult to use
getcwdwithoutMAXPATHLEN, so set a default value if it has not been defined in<sys/param.h>.This allows openpmix to build for hurd.
The patch is taken from debian,
https://salsa.debian.org/science-team/pmix/-/blob/e29db6a5b8e523a3b5e0d80922d5958a0d8e0d07/debian/patches/hurd-fix.patch
and has been successfully tested in debian hurd builds, e.g.
https://buildd.debian.org/status/fetch.php?pkg=pmix&arch=hurd-amd64&ver=6.0.0-3&stamp=1756199722&raw=0
Closes: #3671