Merged
Conversation
* OpenPMIx-bindings Python Versions CI checks
- Builds OpenPMIx Python bindings across different Python versions
- Uses reusable actions that are driven by python-bindings workflow
o Actions: .github/actions/build-python-bindings/action.yaml
o Workflows: .github/workflows/python-bindings.yaml
- Setup to get Python per-version results
- Split actions/workflow to reduce duplicate code, and
easily add new Python versions (in workflows matrix).
- Currently only test CPython
- CI runs limited to pull-requests only (on: pull_request)
- CI manually trigger on main repo via 'Run Workflow' (on: workflow_dispatch)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov>
(cherry picked from commit c690de9)
* Fix Cython 'long' integer error: - Avoids issue for now deprecated use of 'long' integer. - As of Python 3.x no longer make this distinction. - See also: https://wiki.python.org/moin/PortingExtensionModulesToPy3k#long-int-unification Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 684e928)
Need to retain the info structs passed to PMIx_Notify_event until the callback is executed. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 57d71b6)
The pmix_cb_t destructor will release the info array if the infocopy field is set to true. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 51a4b67)
We treat a NULL string as boolean "true", which means that the show-load-errors param was defaulting to "all". Change the default configuration option --with-show-load-errors to be "none" so we avoid that behavior. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 3657e41)
Hide the warnings about bad prefixes behind a verbosity check - only active if show-load-errors is set as well. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit f28cdd7)
Need to provide a callback function so that the notify procedure can correctly release the code for the next step in debugger rendezvous Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 6eb0177)
Check the return code to see if we need to wait for thread release. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 69f7e7e)
The length of time we wait for client finalize to be ack'd by the server is pretty arbitrary - the timeout is there just to avoid having a client "hang" forever if the server is stuck. So let the user adjust the time via MCA param in the case where they need a long time, and set the default to something higher (i.e., 10 sec) than what we were using just in case they have a heavily loaded server. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 85bc673)
Allow pmix.iof.file to output to an existing directory Signed-off-by: Matthew Whitlock <mwhitlo@sandia.gov> (cherry picked from commit 5995438)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github: add python-version checks for bindings
o Actions: .github/actions/build-python-bindings/action.yaml
o Workflows: .github/workflows/python-bindings.yaml
easily add new Python versions (in workflows matrix).
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit c690de9)
bindings: fix Python 3.x error for 'long' integer
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 684e928)
Properly trigger the "keepalive failed" event
Need to retain the info structs passed to
PMIx_Notify_event until the callback is
executed.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 57d71b6)
Ensure cleanup of allocated pmix_info_t
The pmix_cb_t destructor will release the info
array if the infocopy field is set to true.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 51a4b67)
Change default show-load-errors to "none"
We treat a NULL string as boolean "true", which means that
the show-load-errors param was defaulting to "all". Change
the default configuration option --with-show-load-errors
to be "none" so we avoid that behavior.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 3657e41)
Only report bad prefix if verbose requested
Hide the warnings about bad prefixes behind a verbosity
check - only active if show-load-errors is set as well.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit f28cdd7)
Correct client notify of ready for debugger
Need to provide a callback function so that the notify
procedure can correctly release the code for the next
step in debugger rendezvous
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 6eb0177)
Check return code for notify ready-for-debug
Check the return code to see if we need to wait
for thread release.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 69f7e7e)
Parameterize client finalize timeout
The length of time we wait for client finalize to be
ack'd by the server is pretty arbitrary - the timeout
is there just to avoid having a client "hang" forever
if the server is stuck. So let the user adjust the time
via MCA param in the case where they need a long time,
and set the default to something higher (i.e., 10 sec)
than what we were using just in case they have a heavily
loaded server.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 85bc673)
IOF output file bugfix
Allow pmix.iof.file to output to an existing directory
Signed-off-by: Matthew Whitlock mwhitlo@sandia.gov
(cherry picked from commit 5995438)