Ensure to threadshift callback functions#3601
Merged
rhc54 merged 1 commit intoopenpmix:masterfrom May 20, 2025
Merged
Conversation
The server's callback functions are expected to be executed in the host's progress thread. However, it is possible that the host could execute it in the server's upcall to them - we ask that they don't, but no guarantee. So in the interest of protecting against that scenario, and to minimize time spent in their progress thread, ensure we threadshift the callback function before processing it. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server's callback functions are expected to be executed in the host's progress thread. However, it is possible that the host could execute it in the server's upcall to them - we ask that they don't, but no guarantee. So in the interest of protecting against that scenario, and to minimize time spent in their progress thread, ensure we threadshift the callback function before processing it.