Merged
Conversation
If someone mistakenly provides an incorrect path for the directory where we will be storing the shmem backing file (e.g., pass a relative directory and then change the working directory), then we segfault in shmem2 because of a stale job object in the tracking system. So ensure we cleanup the job object when that happens so we can cleanly fallover to "hash". Remove a bunch of error logs when this happens since we are not going to fail, but instead continue running. Add some debug output to report which file was attempted to be opened. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit d8d8b69)
Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix segfault on error in shmem2
If someone mistakenly provides an incorrect path for the
directory where we will be storing the shmem backing file
(e.g., pass a relative directory and then change the
working directory), then we segfault in shmem2 because
of a stale job object in the tracking system. So ensure
we cleanup the job object when that happens so we can
cleanly fallover to "hash".
Remove a bunch of error logs when this happens since we are
not going to fail, but instead continue running. Add some
debug output to report which file was attempted to be opened.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit d8d8b69)
Update NEWS
Signed-off-by: Ralph Castain rhc@pmix.org
bot:notacherrypick