Merged
Conversation
Try to more fully explore the publish-lookup race condition Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit c6cf013)
Rather than exiting configure with an error, print a warning if lto-based directives are detected and ignore those flags. This may help resolve rpm problems. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit af25b7c)
When outputting a show_help message that fails to find the specified topic file, output all locations attempted so the user can see what was done. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit f046625)
Check that we correctly unpublish data for given persistence levels. Add the pubstress test to the CI. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit b19f050)
The use of PMIX_PREFIX in a spawn request was getting
confused, so add some text clarifying it in pmix_common.h.
```text
(char*) prefix to be used by an app to look for its
PMIx installation on remote nodes. A NULL
value indicates that no prefix is to be given
```
Cleanup the client spawn code to reflect that clarification.
Specifically, we are NOT prefixing the location of the
executable - we are instead asking the host to:
(a) setup the LD_LIBRARY_PATH to start with the prefix/lib
location, and
(b) push `PMIX_PREFIX=<value given>` into the app's environment
If the value given is NULL, then we want the host NOT to
assign any prefix to the app, even if there is a default
one at their level
Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit fc0a55b)
When we see the OPAL_PREFIX envar, we need to not only propagate it, but we also need to modify LD_LIBRARY_PATH accordingly so that the app can find its components. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit c445afe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new pub-lookup stress example
Try to more fully explore the publish-lookup race
condition
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit c6cf013)
Just ignore any lto settings
Rather than exiting configure with an error, print a warning
if lto-based directives are detected and ignore those flags.
This may help resolve rpm problems.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit af25b7c)
Have show_help output all directories tried
When outputting a show_help message that fails to find
the specified topic file, output all locations attempted
so the user can see what was done.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit f046625)
Extend the pubstress test and add it to CI
Check that we correctly unpublish data for given
persistence levels. Add the pubstress test to
the CI.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit b19f050)
Cleanup spawn and clarify attribute comment
The use of PMIX_PREFIX in a spawn request was getting
confused, so add some text clarifying it in pmix_common.h.
Cleanup the client spawn code to reflect that clarification.
Specifically, we are NOT prefixing the location of the
executable - we are instead asking the host to:
(a) setup the LD_LIBRARY_PATH to start with the prefix/lib
location, and
(b) push
PMIX_PREFIX=<value given>into the app's environmentIf the value given is NULL, then we want the host NOT to
assign any prefix to the app, even if there is a default
one at their level
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit fc0a55b)
Properly handle OPAL_PREFIX
When we see the OPAL_PREFIX envar, we need to not only
propagate it, but we also need to modify LD_LIBRARY_PATH
accordingly so that the app can find its components.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit c445afe)