Merged
Conversation
We cannot block in an upcall into the host, so do the right thing and allow the host to callback asynchronously when servicing a "resolve" request Signed-off-by: Ralph Castain <rhc@pmix.org> Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit ce3f5a4)
If the host supports the "query" upcall interface, they will return SUCCESS to mean that they are servicing the request. It does not mean that they will understand the key(s) being passed to them - in which case, they will issue the callback with some status other than SUCCESS. Should that happen, we still want the server to attempt to resolve the request to the best of its ability. So provide a mechanism by which the server gets a second shot at providing the answer. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 76bd862)
When executed as a singleton, we automatically search for available connections, just like a tool would do. However, if they are not found, we should not emit an error message if we were not specifically directed to find one - e.g., a system-level server. Also fix the query operation to return any partial results it was able to find when operating as a singleton. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 2a762ff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not block in query upcall
We cannot block in an upcall into the host, so do the right
thing and allow the host to callback asynchronously when
servicing a "resolve" request
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ce3f5a4)
Further cleanup of "resolve" functions
If the host supports the "query" upcall interface, they
will return SUCCESS to mean that they are servicing the
request. It does not mean that they will understand the
key(s) being passed to them - in which case, they will
issue the callback with some status other than SUCCESS.
Should that happen, we still want the server to attempt
to resolve the request to the best of its ability. So
provide a mechanism by which the server gets a second
shot at providing the answer.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 76bd862)
Silence error output when running as singleton
When executed as a singleton, we automatically search
for available connections, just like a tool would do.
However, if they are not found, we should not emit an
error message if we were not specifically directed
to find one - e.g., a system-level server.
Also fix the query operation to return any partial
results it was able to find when operating as
a singleton.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 2a762ff)