Merged
Conversation
Update the "pctrl" tool so it correctly exits with zero status when asked for "help" or "version". Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 1424b4f)
Resolve the hang in the blocking query API. Strip out the unnecessary code. Cache results as we go so we don't lose initial results when we go to the server and/or the host. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 7c0165e)
Add `--enable-devel-check` to all configure lines Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit fafe63c)
Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit da99e5e)
When a client asks the server for information, the server must format the response to match the PMIx version employed by the client. We were incorrectly formatting the response on the basis of the version declared by the process whose data was being requested - as opposed to the version of the _requestor_. In the case of tools, this led to an incorrectly formatted response, particularly for node-level data where earlier PMIx versions didn't support the node-info array. Looking at this also exposed that the client's version was defaulting to 0.0.0, and would remain that way if the client application did not call PMIx_Init. Needed to adjust the macro that checks for PMIx version level to deal with non-PMIx clients. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a140bd7)
Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit with correct status after displaying help or version
Update the "pctrl" tool so it correctly exits with zero
status when asked for "help" or "version".
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 1424b4f)
Revamp the query implementation
Resolve the hang in the blocking query API. Strip out the
unnecessary code. Cache results as we go so we don't lose
initial results when we go to the server and/or the host.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 7c0165e)
Update CI workflows
Add
--enable-devel-checkto all configure linesSigned-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit fafe63c)
Silence warnings exposed by updated CI
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit da99e5e)
Fix format of fetch response for peer's version
When a client asks the server for information, the server
must format the response to match the PMIx version employed
by the client. We were incorrectly formatting the response
on the basis of the version declared by the process whose
data was being requested - as opposed to the version of
the requestor.
In the case of tools, this led to an incorrectly formatted
response, particularly for node-level data where earlier
PMIx versions didn't support the node-info array.
Looking at this also exposed that the client's version
was defaulting to 0.0.0, and would remain that way if
the client application did not call PMIx_Init. Needed
to adjust the macro that checks for PMIx version level
to deal with non-PMIx clients.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit a140bd7)
bot:notacherrypick