Skip to content

Multiple commits#3545

Merged
rhc54 merged 6 commits intoopenpmix:v5.0from
rhc54:cmr50/up
Feb 21, 2025
Merged

Multiple commits#3545
rhc54 merged 6 commits intoopenpmix:v5.0from
rhc54:cmr50/up

Conversation

@rhc54
Copy link
Contributor

@rhc54 rhc54 commented Feb 21, 2025

Exit with correct status after displaying help or version

Update the "pctrl" tool so it correctly exits with zero
status when asked for "help" or "version".

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 1424b4f)

Revamp the query implementation

Resolve the hang in the blocking query API. Strip out the
unnecessary code. Cache results as we go so we don't lose
initial results when we go to the server and/or the host.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 7c0165e)

Update CI workflows

Add --enable-devel-check to all configure lines

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit fafe63c)

Silence warnings exposed by updated CI

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit da99e5e)

Fix format of fetch response for peer's version

When a client asks the server for information, the server
must format the response to match the PMIx version employed
by the client. We were incorrectly formatting the response
on the basis of the version declared by the process whose
data was being requested - as opposed to the version of
the requestor.

In the case of tools, this led to an incorrectly formatted
response, particularly for node-level data where earlier
PMIx versions didn't support the node-info array.

Looking at this also exposed that the client's version
was defaulting to 0.0.0, and would remain that way if
the client application did not call PMIx_Init. Needed
to adjust the macro that checks for PMIx version level
to deal with non-PMIx clients.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit a140bd7)

bot:notacherrypick

Update the "pctrl" tool so it correctly exits with zero
status when asked for "help" or "version".

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 1424b4f)
Resolve the hang in the blocking query API. Strip out the
unnecessary code. Cache results as we go so we don't lose
initial results when we go to the server and/or the host.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 7c0165e)
Add `--enable-devel-check` to all configure lines

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit fafe63c)
Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit da99e5e)
When a client asks the server for information, the server
must format the response to match the PMIx version employed
by the client. We were incorrectly formatting the response
on the basis of the version declared by the process whose
data was being requested - as opposed to the version of
the _requestor_.

In the case of tools, this led to an incorrectly formatted
response, particularly for node-level data where earlier
PMIx versions didn't support the node-info array.

Looking at this also exposed that the client's version
was defaulting to 0.0.0, and would remain that way if
the client application did not call PMIx_Init. Needed
to adjust the macro that checks for PMIx version level
to deal with non-PMIx clients.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit a140bd7)
Signed-off-by: Ralph Castain <rhc@pmix.org>
@rhc54 rhc54 merged commit f92a222 into openpmix:v5.0 Feb 21, 2025
23 checks passed
@rhc54 rhc54 deleted the cmr50/up branch February 21, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant