Merged
Conversation
We made some changes to the os_dirpath_create code a while back to resolve some of the "test-before-use" warnings and other things. However, this opened a hole in the logic of the PTL code that used it. Specifically, we weakened the connection between when a file and directory were being created by the tool itself, and when those things already existed. So we could inadvertently stomp on files. Do a better job of tracking precisely which directories and files are being created by a given process...and then ONLY remove those that were created by it. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 445d4af)
Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 3c65fc8)
Signed-off-by: Ralph Castain <rhc@pmix.org>
Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair the file removal code
We made some changes to the os_dirpath_create code a while back
to resolve some of the "test-before-use" warnings and other
things. However, this opened a hole in the logic of the PTL
code that used it. Specifically, we weakened the connection
between when a file and directory were being created by the
tool itself, and when those things already existed. So we could
inadvertently stomp on files.
Do a better job of tracking precisely which directories and
files are being created by a given process...and then ONLY
remove those that were created by it.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 445d4af)
Add a --nogreek option to make tarball
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 3c65fc8)
Update PRRTE CI to point at PRRTE v3.0 branch
fbde493
Signed-off-by: Ralph Castain rhc@pmix.org
Cleanup a segfault when the host refuses group construct support
Signed-off-by: Ralph Castain rhc@pmix.org
bot:notacherrypick