Merged
Conversation
When calling PMIx_Resolve_peers, the client may not be able to find the job-level info for the specified nspace. In this case, it requests the info from the server. The server's copy of the info is sometimes stored as rank=UNDEF, but can also be stored as rank=WILDCARD (depending on the server's version). So the client has to check both rank values to ensure the data is found. Fortunately, it only requires one exchange with the server regardless of which rank is being used. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit c9efd8d)
Some minor code cleanups, mostly in debug statements. Add an example of how to use the "resolve" APIs. IMPORTANT NOTE: when you spawn a child job and want to collect job-level info on it, you MUST use PMIx_Connect to share the info across parent and child jobs. Using PMIx_Fence - even with the "collect data" flag - only shares the data that each process "put" - it does _not_ include job-level data. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 39adf49)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix resolve peers for other nspaces
When calling PMIx_Resolve_peers, the client may not be
able to find the job-level info for the specified nspace.
In this case, it requests the info from the server. The
server's copy of the info is sometimes stored as rank=UNDEF,
but can also be stored as rank=WILDCARD (depending on the
server's version). So the client has to check both rank
values to ensure the data is found.
Fortunately, it only requires one exchange with the server
regardless of which rank is being used.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit c9efd8d)
Minor cleanups plus resolve peers example
Some minor code cleanups, mostly in debug statements. Add
an example of how to use the "resolve" APIs.
IMPORTANT NOTE: when you spawn a child job and want to
collect job-level info on it, you MUST use PMIx_Connect
to share the info across parent and child jobs. Using
PMIx_Fence - even with the "collect data" flag - only
shares the data that each process "put" - it does not
include job-level data.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 39adf49)