Merged
Conversation
Do not include a terminator element in the pmix_dictionary, but instead rely on the defined number of entries as the length of the array. Since user-defined keys can be different on each process, and/or appear in different order, we cannot define a unique index for them. Each process will assign their own index when those keys are "put", and we currently have no way to go back into the hash storage to "reset" those values. So we have to push all returned modex values into the local hash for now. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit c38aef6) Signed-off-by: Ralph Castain <rhc@pmix.org>
Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov> (cherry picked from commit c3ae2d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure server and client indices are in sync
Do not include a terminator element in the pmix_dictionary, but
instead rely on the defined number of entries as the length
of the array. Since user-defined keys can be different on
each process, and/or appear in different order, we cannot
define a unique index for them. Each process will assign
their own index when those keys are "put", and we currently
have no way to go back into the hash storage to "reset"
those values. So we have to push all returned modex values
into the local hash for now.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit c38aef6)
Signed-off-by: Ralph Castain rhc@pmix.org
Remove unused function in shmem2.
Signed-off-by: Samuel K. Gutierrez samuel@lanl.gov
(cherry picked from commit c3ae2d0)