Implement OpenPGP message grammar validation (add config.enforceGrammar)#1853
Merged
twiss merged 3 commits intoopenpgpjs:mainfrom May 20, 2025
Merged
Implement OpenPGP message grammar validation (add config.enforceGrammar)#1853twiss merged 3 commits intoopenpgpjs:mainfrom
config.enforceGrammar)#1853twiss merged 3 commits intoopenpgpjs:mainfrom
Conversation
To access the types in internally. Also, include internal d.ts files in published npm bundle.
To access the types in internally
…mar`) It enforces a message structure as defined in https://www.rfc-editor.org/rfc/rfc9580.html#section-10.3 (but slightly more permissive with Padding packets allowed in all cases). Since we are unclear on whether this change might impact handling of some messages in the wild, generated by odd use-cases or non-conformant implementations, we also add the option to disable the grammar check via `config.enforceGrammar`. GrammarErrors are only sensitive in the context of unauthenticated decrypted streams.
twiss
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the lib enforces a message structure as defined in https://www.rfc-editor.org/rfc/rfc9580.html#section-10.3, but slightly more permissive with Padding packets allowed in all cases, and standalone encrypted session key packets (ESK) also permitted.
Since we are unclear on whether this change might impact handling of some messages in the wild, generated by
odd use-cases or non-conformant implementations, we also add the option to disable the grammar check via
config.enforceGrammar(on by default).