[v6] enums.curve: rename NIST curves and clean up unused internal values#1721
Merged
larabr merged 3 commits intoopenpgpjs:v6from Feb 2, 2024
Merged
[v6] enums.curve: rename NIST curves and clean up unused internal values#1721larabr merged 3 commits intoopenpgpjs:v6from
enums.curve: rename NIST curves and clean up unused internal values#1721larabr merged 3 commits intoopenpgpjs:v6from
Conversation
… `.nistP{256, 384, 521}`
Also, cleanup `enums.curves` removing internal aliases which are no longer relevant.
twiss
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the standardisation of the Brainpool curves as part of the crypto-refresh, we are renaming the NIST curves to avoid ambiguities.
This is a breaking change, as NIST curves identifiers and values in
enums.curveshave been renamed:enums.curve.p256,.p384,.p521are now marked as@deprecatedenums.curve.nistP256,.nistP384,.nistP521.'p256','p384','p521'to'nistP256','nistP384','nistP521'.Affected high-level API functions:
generateKey, theoptions.curveargument will expect the updated string valuesKey.getAlgorithmInfo()will return the updatedcurvevalues