[v6] Use Compression Stream API when available, drop config.deflateLevel#1717
Merged
larabr merged 1 commit intoopenpgpjs:v6from Feb 1, 2024
Merged
[v6] Use Compression Stream API when available, drop config.deflateLevel#1717larabr merged 1 commit intoopenpgpjs:v6from
config.deflateLevel#1717larabr merged 1 commit intoopenpgpjs:v6from
Conversation
twiss
approved these changes
Jan 26, 2024
5e9df8f to
8c2c6cf
Compare
If Compression Stream API is not available, fallback to fflate, also in Node. The `config.deflateLevel` is removed as the API does not accept a deflate level in input, and the setting is of limited importance. Plus, using compression is discouraged on security grounds.
8c2c6cf to
0fd1914
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Compression Stream API is now implemented on all platforms: https://developer.mozilla.org/en-US/docs/Web/API/Compression_Streams_API .
Breaking change:
config.deflateLevelhas been dropped. The Compression Stream API does not accept a deflate level in input, and since using compression is now discouraged on security grounds, we drop the config option altogether.