fix(cloudflare): fix the node wrapper#661
Closed
vicb wants to merge 1 commit into
Closed
Conversation
Returns the response converted from the internal event. It fixes a "This ReadableStream did not return bytes" workerd error.
🦋 Changeset detectedLatest commit: 1e7be14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
commit: |
conico974
reviewed
Dec 3, 2024
| ctx.waitUntil(handler(internalEvent, streamCreator)); | ||
|
|
||
| return promiseResponse; | ||
| const internalResult = await handler(internalEvent, streamCreator); |
Contributor
There was a problem hiding this comment.
It may fix it, but it also means that streaming will not work.
The handler in node returns only after the response is fully sent (and the streamCreator is not useful in this case)
Maybe using a custom Writable with a custom ReadableStream would help figure out what's the issue here (or resolving the response in onWrite (this may break other things, but at least it'll help figure out what's going on here)
Contributor
Author
|
superseded by #664 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns the response converter from the internal event.
It fixes a "This ReadableStream did not return bytes" workerd error.