-
-
Notifications
You must be signed in to change notification settings - Fork 212
Fix backwards compatibility #646. #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…atype was used in pickle.
|
I get a consistent error, but this also happens on the current develop head (tested locally): These seem to be server issues. is my best bet. If I try to filter runs with the tag through the website then over 6k results are returned quickly, but through the API I got the following response: edit: requesting the response through my webbrowser is similarly slow (and has the same result). |
|
Seems like joining to the run tag column is extremely slow (I guess due to the large size). This could be solved by adding an index on the tag name, at the expense of additional disk cost. We currently have 23M run tag records, mostly indicating stuff that can be obtained through other ways as well. I think we should review the utility of (run) tags, and when a library automatically adds a tag to a run. |
|
|
website runs on ES, which is an index build upon the database. I am surprised that the query returns no results. It should either crash or return 6000+ results. |
|
It does seem odd. Either way, I think we're best served by skipping this unit test for now as it is not an issue with the Python code. So I'll go ahead and do that (also @mfeurer so he knows what's up too). |
|
@PGijsbers feel free to open an issue about this in the main tracker, with tags 'CoreSystem' and 'highest priority' assigned to me. I can't solve it this week (ECML deadline) but it will be high on my priority list |
Codecov Report
@@ Coverage Diff @@
## develop #654 +/- ##
===========================================
- Coverage 90.96% 90.94% -0.03%
===========================================
Files 32 32
Lines 3388 3391 +3
===========================================
+ Hits 3082 3084 +2
- Misses 306 307 +1
Continue to review full report at Codecov.
|
mfeurer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!



See #646. Reprocess ARFF file if outdated datatype was used in pickle.
No unit tests are currently added. To add unit tests we would also need to add more data files (of outdated data) to the repository. That just doesn't seem worth it. Changes were tested locally by updating my local cache :) I will add unit tests if requested. The code changed in this patch is so minimal that I feel confident enough if the current unit tests don't break.