7903960: JMH: Add Maven Wrapper integration#154
Conversation
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Maven Wrapper must be run as an executable, it does not support being passed as a parameter to |
|
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@vy This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
OpenJDK projects don't allow executable files, yet `sh mvnw` was broken[1]. The issue is fixed in Maven Wrapper `3.3.3`. [1]: https://issues.apache.org/jira/browse/MWRAPPER-161
|
/open |
|
@vy This pull request is now open |
Webrevs
|
|
@vy This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Withdrawing this work due to lack of interest. |
Adds Maven Wrapper integration. See the ticket description for details.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/154/head:pull/154$ git checkout pull/154Update a local copy of the PR:
$ git checkout pull/154$ git pull https://git.openjdk.org/jmh.git pull/154/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 154View PR using the GUI difftool:
$ git pr show -t 154Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/154.diff
Using Webrev
Link to Webrev Comment