8251941: ListCell: visual artifact when items contain null values#288
8251941: ListCell: visual artifact when items contain null values#288kleopatra wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back fastegal! A progress list of the required criteria for merging this PR into |
|
Looks OK. |
|
@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 3 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@kleopatra The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit c86bd35. |
The issue describes the makroscopic effect/s, namely content showing in cells that are off range.
The base reason is missing cleanup of the cell on transition from not-empty to empty when the old item is a null contained in the items. Fixed by changing the logic to cope with that special case. Added tests that fail before and pass after the fix.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/288/head:pull/288$ git checkout pull/288