Skip to content

8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder#66

Closed
mlchung wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:mlchung-backport-bc8e9f44
Closed

8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder#66
mlchung wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:mlchung-backport-bc8e9f44

Conversation

@mlchung

@mlchung mlchung commented Aug 16, 2023 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown
Member

Hi all,

This pull request contains a backport of commit bc8e9f44 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Schwentker on 15 Aug 2023 and was reviewed by Mandy Chung.

This is an additional test added for #65.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/66/head:pull/66
$ git checkout pull/66

Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.org/jdk21u.git pull/66/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 66

View PR using the GUI difftool:
$ git pr show -t 66

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/66.diff

Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 16, 2023

Copy link
Copy Markdown

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk Bot changed the title Backport bc8e9f44a39ff59b59b2d1d5d546a148be75a2f2 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder Aug 16, 2023
@openjdk

openjdk Bot commented Aug 16, 2023

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 16, 2023
@openjdk

openjdk Bot commented Aug 16, 2023

Copy link
Copy Markdown

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2023
@mlchung mlchung mentioned this pull request Aug 16, 2023
Closed
3 tasks
@mlbridge

mlbridge Bot commented Aug 16, 2023

Copy link
Copy Markdown

Webrevs

@mlchung

mlchung commented Aug 31, 2023

Copy link
Copy Markdown
Member Author

@phohensee you reviewed #65. This is a new test going with the fix. Do you mind reviewing this PR as well?

@mlchung

mlchung commented Sep 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

This PR is replaced with #127.

@mlchung mlchung closed this Sep 1, 2023
@phohensee phohensee mentioned this pull request Sep 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mlchung