👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into pr/4265 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281243: Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 057fe14: Merge
• e33f6f6: 8380078: Update GIFlib to 6.1.2
• 14b779e: 8379256: Update GIFlib to 6.1.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

This backport pull request has now been updated with issue from the original commit.

Webrevs

• 02: Full - Incremental (bf3ae4e4)
• 01: Full - Incremental (e81a7017)
• 00: Full (e81a7017)

tests on windows are failing here:

Generating symbol list from object files
gawk: cmd. line:1: error: ? * + or {interval} not preceded by valid subpattern: /??_7.*@@6B@/
make[3]: *** [lib/JvmMapfile.gmk:116: /d/a/jdk17u-dev/jdk17u-dev/build/windows-aarch64/hotspot/variant-server/libjvm/symbols-objects] Error 1
make[3]: *** Deleting file '/d/a/jdk17u-dev/jdk17u-dev/build/windows-aarch64/hotspot/variant-server/libjvm/symbols-objects'
make[3]: Target 'default' not remade because of errors.
make[2]: *** [make/Main.gmk:252: hotspot-server-libs] Error 2
make[2]: Target 'hotspot' not remade because of errors.

ERROR: Build failed for target 'hotspot' in configuration 'windows-aarch64' (exit code 2) 

I don't understand why it fails now. Seems not related to the change
Anybody has an idea?

Yes, that is unrelated. It is fixed by 8314555: Build with mawk fails on Windows

Yes, that is unrelated. It is fixed by 8314555: Build with mawk fails on Windows

Do I need to do something then about it then regarding this PR?

You could merge head, this would restart the test.
But given the nature of this change I think the chance that the run on Win unveils an issue with this change is tiny.

/approval 8281243 request

@jpbempel
8281243: The approval request has been created successfully.

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout backport-jpbempel-95fd9d20-master
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

/integrate

@jpbempel
Your change (at version bf3ae4e) is now ready to be sponsored by a Committer.

/sponsor

Going to push as commit d39baa5.
Since your change was applied there have been 3 commits pushed to the master branch:

• 057fe14: Merge
• e33f6f6: 8380078: Update GIFlib to 6.1.2
• 14b779e: 8379256: Update GIFlib to 6.1.1

Your commit was automatically rebased without conflicts.

@phohensee @jpbempel Pushed as commit d39baa5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.