Skip to content

JDK-8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration#417

Closed
jonathan-gibbons wants to merge 1 commit intoopenjdk:masterfrom
jonathan-gibbons:8253700.extends-Throwable
Closed

JDK-8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration#417
jonathan-gibbons wants to merge 1 commit intoopenjdk:masterfrom
jonathan-gibbons:8253700.extends-Throwable

Conversation

@jonathan-gibbons
Copy link
Copy Markdown
Contributor

@jonathan-gibbons jonathan-gibbons commented Sep 29, 2020 •
edited by openjdk Bot
Loading

The link for the throws type was not filtering out the bounds. A new LinkInfoImpl.Kind is added for THROWS_TYPE.

The loop to generate the list of exceptions is simplified.

A new test is provided. The generated API for Optional.orElseThrow has also been verified as correct.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/417/head:pull/417
$ git checkout pull/417

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Sep 29, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Sep 29, 2020
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Sep 29, 2020

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the javadoc javadoc-dev@openjdk.org label Sep 29, 2020
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Sep 29, 2020

Webrevs

@pavelrappo
Copy link
Copy Markdown
Member

pavelrappo commented Sep 30, 2020

/test tier1

pavelrappo
pavelrappo reviewed Sep 30, 2020
View reviewed changes
Comment thread .../share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java
Comment on lines +259 to +265
for (TypeMirror t : exceptions) {
if (!htmlTree.isEmpty()) {
htmlTree.add(",");
htmlTree.add(DocletConstants.NL);
}
Content link = writer.getLink(new LinkInfoImpl(configuration, THROWS_TYPE, t));
htmlTree.add(link);
Copy link
Copy Markdown
Member

@pavelrappo pavelrappo Sep 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me of the 8238966: Use a better way of joining things together.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Sep 30, 2020

Could not create test job

pavelrappo
pavelrappo approved these changes Sep 30, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@pavelrappo pavelrappo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The crux of the fix is really small.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Sep 30, 2020 •
edited
Loading

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 4c65365: 8253792: javax.swing.text.GapContent documentation typos
  • 3078b5f: 6441211: Small Error in API at javax.swing.plaf.synth.Region
  • 4622a18: 8253791: Issue with useAppleColor check in CSystemColors.m
  • ac02afe: 8253721: Flag -XX:AVX3Threshold does not accept Zero value
  • 4d9f207: 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac
  • 1eca634: 8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb
  • a55cde4: 8252002: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdwp
  • ffc97ba: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • 5310d85: 8252937: Correct "no comment" warnings from javadoc in java.math package

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Sep 30, 2020
@pavelrappo
Copy link
Copy Markdown
Member

pavelrappo commented Sep 30, 2020

Could not create test job

This will not be forgotten, bot.

@jonathan-gibbons
Copy link
Copy Markdown
Contributor Author

jonathan-gibbons commented Sep 30, 2020

/integrate

@openjdk openjdk Bot closed this Sep 30, 2020
@openjdk openjdk Bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 30, 2020
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Sep 30, 2020

@jonathan-gibbons Since your change was applied there have been 15 commits pushed to the master branch:

  • 8b3d676: 8238737: remove DeoptimizeAllClassesRate from CTW library
  • 709cfe5: 8253815: Remove unused HeapRegionManager::_num_committed from SA
  • f80a606: 8253375: OSX build fails with Xcode 12.0 (12A7209)
  • 04775f1: 8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).
  • dc3a0f5: 8253183: Fragile memory barrier selection for some weak memory model platforms
  • 8331e63: 8253778: ShenandoahSafepoint::is_at_shenandoah_safepoint should not access VMThread state from other threads
  • 4c65365: 8253792: javax.swing.text.GapContent documentation typos
  • 3078b5f: 6441211: Small Error in API at javax.swing.plaf.synth.Region
  • 4622a18: 8253791: Issue with useAppleColor check in CSystemColors.m
  • ac02afe: 8253721: Flag -XX:AVX3Threshold does not accept Zero value
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/8df3e72cea9217a7a10e2ac4bf4d1501a7fad43c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8cf8e46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk Bot removed the rfr Pull request is ready for review label Sep 30, 2020
@jonathan-gibbons jonathan-gibbons deleted the 8253700.extends-Throwable branch November 4, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pavelrappo pavelrappo pavelrappo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonathan-gibbons @pavelrappo