8182043: Access to Windows Large Icons#2875
Closed
azuev-java wants to merge 18 commits into
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix updated after first round of review.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2875/head:pull/2875$ git checkout pull/2875Update a local copy of the PR:
$ git checkout pull/2875$ git pull https://git.openjdk.java.net/jdk pull/2875/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2875View PR using the GUI difftool:
$ git pr show -t 2875Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2875.diff