Skip to content

Conversation

@dev-jonghoonpark
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark commented Aug 13, 2025

This change updates TestReclaimStringsLeaksMemory.java to properly guard against unsupported GC arguments.
Previously, the test only checked @requires vm.gc == "null".

The fix separates the tests and adds explicit @requires clauses for each GC configuration to ensure the test only runs when supported.

This prevents test failures on VMs that do not support the specified GC.

(This is my first contribution to the JDK. Thank you for your review and guidance.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26766/head:pull/26766
$ git checkout pull/26766

Update a local copy of the PR:
$ git checkout pull/26766
$ git pull https://git.openjdk.org/jdk.git pull/26766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26766

View PR using the GUI difftool:
$ git pr show -t 26766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26766.diff

Using Webrev

Link to Webrev Comment

Signed-off-by: jonghoonpark <dev@jonghoonpark.com>
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

Hi @dev-jonghoonpark, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dev-jonghoonpark" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java

Reviewed-by: tschatzl, stefank, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 417 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @stefank, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@dev-jonghoonpark The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 13, 2025
@dev-jonghoonpark
Copy link
Contributor Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Aug 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Sep 2, 2025
@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@dev-jonghoonpark this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8364927-add-requires-annotation
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch rfr Pull request is ready for review labels Sep 2, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2025

Webrevs

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Sep 2, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 3, 2025
Signed-off-by: jonghoonpark <dev@jonghoonpark.com>
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 3, 2025
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. HotSpot reviews require two reviewers to approve the change so make sure to get a second approval of your latest change.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 3, 2025
@dev-jonghoonpark
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@dev-jonghoonpark
Your change (at version 09b5f7c) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

tschatzl commented Oct 6, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 6, 2025

Going to push as commit 2bfada3.
Since your change was applied there have been 417 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2025
@openjdk openjdk bot closed this Oct 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 6, 2025
@openjdk
Copy link

openjdk bot commented Oct 6, 2025

@tschatzl @dev-jonghoonpark Pushed as commit 2bfada3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants