Skip to content

8341346: Add support for exporting TLS Keying Material#24976

Closed
bradfordwetmore wants to merge 41 commits intoopenjdk:masterfrom
bradfordwetmore:JDK-8341346
Closed

8341346: Add support for exporting TLS Keying Material#24976
bradfordwetmore wants to merge 41 commits intoopenjdk:masterfrom
bradfordwetmore:JDK-8341346

Conversation

@bradfordwetmore
Copy link
Copy Markdown
Contributor

@bradfordwetmore bradfordwetmore commented Apr 30, 2025 •
edited by openjdk bot
Loading

Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE respectively.

CSR is complete/approved.

Tests include new unit tests for TLSv1-1.3. Have run tier1-2, plus the JCK API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net jck:api/javax_security jck:api/org_ietf jck:api/javax_xml/crypto)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8348370 to be approved

Issues

  • JDK-8341346: Add support for exporting TLS Keying Material (Enhancement - P3)
  • JDK-8348370: Add support for exporting TLS Keying Material (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24976/head:pull/24976
$ git checkout pull/24976

Update a local copy of the PR:
$ git checkout pull/24976
$ git pull https://git.openjdk.org/jdk.git pull/24976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24976

View PR using the GUI difftool:
$ git pr show -t 24976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24976.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 30, 2025

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 30, 2025 •
edited
Loading

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341346: Add support for exporting TLS Keying Material

Reviewed-by: hchao, jnimeh, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0df8c96: 8353686: Optimize Math.cbrt for x86 64 bit platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 30, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 30, 2025

@bradfordwetmore The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org net net-dev@openjdk.org labels Apr 30, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 30, 2025 •
edited
Loading

Webrevs

wangweij
wangweij reviewed May 1, 2025
View reviewed changes
artur-oracle
artur-oracle reviewed May 1, 2025
View reviewed changes
artur-oracle
artur-oracle reviewed May 1, 2025
View reviewed changes
artur-oracle
artur-oracle reviewed May 1, 2025
View reviewed changes
wangweij
wangweij reviewed May 7, 2025
View reviewed changes
wangweij
wangweij reviewed May 7, 2025
View reviewed changes
wangweij
wangweij reviewed May 7, 2025
View reviewed changes
@openjdk
Copy link
Copy Markdown

openjdk bot commented May 9, 2025

@bradfordwetmore this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8341346
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label May 9, 2025
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label May 9, 2025
wangweij
wangweij reviewed May 29, 2025
View reviewed changes
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 29, 2025
@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels May 30, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 30, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 30, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 30, 2025
@bradfordwetmore
Copy link
Copy Markdown
Contributor Author

bradfordwetmore commented May 30, 2025

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented May 30, 2025

Going to push as commit 2926435.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 0df8c96: 8353686: Optimize Math.cbrt for x86 64 bit platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 30, 2025
@openjdk openjdk bot closed this May 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2025
@openjdk
Copy link
Copy Markdown

openjdk bot commented May 30, 2025

@bradfordwetmore Pushed as commit 2926435.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bradfordwetmore bradfordwetmore deleted the JDK-8341346 branch July 23, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

6 more reviewers

@djelinski djelinski djelinski left review comments

@seanjmullan seanjmullan seanjmullan left review comments

@artur-oracle artur-oracle artur-oracle left review comments

@wangweij wangweij wangweij approved these changes

@jnimeh jnimeh jnimeh approved these changes

@haimaychao haimaychao haimaychao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integrated Pull request has been integrated net net-dev@openjdk.org security security-dev@openjdk.org

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bradfordwetmore @wangweij @djelinski @seanjmullan @jnimeh @haimaychao @artur-oracle