8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API#22150
8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API#22150asotona wants to merge 1 commit into
Conversation
|
👋 Welcome back asotona! A progress list of the required criteria for merging this PR into |
|
@asotona This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
liach
left a comment
There was a problem hiding this comment.
Sorry for forgetting to leave that review earlier. Viktor told me but I forgot to leave the remark on the PR review.
|
I missed it too. /integrate |
|
Going to push as commit 3c38ed4. |
jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed with JDK-8334714, however it should remain until used in bootstrap build.
Please review.
Thank you,
Adam
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22150/head:pull/22150$ git checkout pull/22150Update a local copy of the PR:
$ git checkout pull/22150$ git pull https://git.openjdk.org/jdk.git pull/22150/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22150View PR using the GUI difftool:
$ git pr show -t 22150Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22150.diff
Using Webrev
Link to Webrev Comment