Skip to content

8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API#22150

Closed
asotona wants to merge 1 commit into
openjdk:masterfrom
asotona:JDK-8344314-preview-back
Closed

8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API#22150
asotona wants to merge 1 commit into
openjdk:masterfrom
asotona:JDK-8344314-preview-back

Conversation

@asotona

@asotona asotona commented Nov 15, 2024

Copy link
Copy Markdown
Member

jdk.internal.java.PreviewFeature.CLASSFILE_API has been accidentally removed with JDK-8334714, however it should remain until used in bootstrap build.

Please review.

Thank you,
Adam


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22150/head:pull/22150
$ git checkout pull/22150

Update a local copy of the PR:
$ git checkout pull/22150
$ git pull https://git.openjdk.org/jdk.git pull/22150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22150

View PR using the GUI difftool:
$ git pr show -t 22150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Nov 15, 2024

Copy link
Copy Markdown

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Nov 15, 2024

Copy link
Copy Markdown

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Nov 15, 2024
@openjdk

openjdk Bot commented Nov 15, 2024

Copy link
Copy Markdown

@asotona The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 15, 2024
@mlbridge

mlbridge Bot commented Nov 15, 2024

Copy link
Copy Markdown

Webrevs

@liach liach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for forgetting to leave that review earlier. Viktor told me but I forgot to leave the remark on the PR review.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Nov 15, 2024
@asotona

asotona commented Nov 15, 2024

Copy link
Copy Markdown
Member Author

I missed it too.
Thanks!

/integrate

@openjdk

openjdk Bot commented Nov 15, 2024

Copy link
Copy Markdown

Going to push as commit 3c38ed4.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Nov 15, 2024
@openjdk openjdk Bot closed this Nov 15, 2024
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2024
@openjdk

openjdk Bot commented Nov 15, 2024

Copy link
Copy Markdown

@asotona Pushed as commit 3c38ed4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants