Skip to content

8303760: Visual Studio should use the primary variant in the IDE#12906

Closed
TheShermanTanker wants to merge 2 commits intoopenjdk:masterfrom
TheShermanTanker:patch-6
Closed

8303760: Visual Studio should use the primary variant in the IDE#12906
TheShermanTanker wants to merge 2 commits intoopenjdk:masterfrom
TheShermanTanker:patch-6

Conversation

@TheShermanTanker
Copy link
Copy Markdown
Contributor

@TheShermanTanker TheShermanTanker commented Mar 7, 2023 •
edited by openjdk bot
Loading

Currently support for Visual Studio development always assumes server as the variant to use. More accurately this should instead be set to the primary variant instead

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303760: Visual Studio should use the primary variant in the IDE

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12906/head:pull/12906
$ git checkout pull/12906

Update a local copy of the PR:
$ git checkout pull/12906
$ git pull https://git.openjdk.org/jdk pull/12906/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12906

View PR using the GUI difftool:
$ git pr show -t 12906

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12906.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 7, 2023

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TheShermanTanker TheShermanTanker mentioned this pull request Mar 7, 2023
Closed
3 tasks
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 7, 2023

@TheShermanTanker The following labels will be automatically applied to this pull request:

  • build
  • ide-support

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org ide-support ide-support-dev@openjdk.org labels Mar 7, 2023
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 7, 2023 •
edited
Loading

Webrevs

@TheShermanTanker
Copy link
Copy Markdown
Contributor Author

TheShermanTanker commented Mar 9, 2023

:(

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 9, 2023

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303760: Visual Studio should use the primary variant in the IDE

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • cdcf5c1: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests
  • 4655b79: 8294982: Implementation of Classfile API
  • 1e9942a: 8303881: Mixed, minor cleanup in jdk.compiler
  • 7e01534: 8303467: Serial: Refactor reference processor
  • 713def0: 8303105: LoopRangeStrideTest fails IR verification on x86

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 9, 2023
@TheShermanTanker
Copy link
Copy Markdown
Contributor Author

TheShermanTanker commented Mar 9, 2023

Thanks Erik!

@TheShermanTanker
Copy link
Copy Markdown
Contributor Author

TheShermanTanker commented Mar 9, 2023

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 9, 2023

Going to push as commit 3227b49.
Since your change was applied there have been 5 commits pushed to the master branch:

  • cdcf5c1: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests
  • 4655b79: 8294982: Implementation of Classfile API
  • 1e9942a: 8303881: Mixed, minor cleanup in jdk.compiler
  • 7e01534: 8303467: Serial: Refactor reference processor
  • 713def0: 8303105: LoopRangeStrideTest fails IR verification on x86

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 9, 2023
@openjdk openjdk bot closed this Mar 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 9, 2023

@TheShermanTanker Pushed as commit 3227b49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheShermanTanker TheShermanTanker deleted the patch-6 branch March 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erikj79 erikj79 erikj79 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build build-dev@openjdk.org ide-support ide-support-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheShermanTanker @erikj79