Skip to content

8297295: Remove ThreadGroup.allowThreadSuspension#11373

Closed
AlanBateman wants to merge 3 commits into
openjdk:masterfrom
AlanBateman:JDK-8297295
Closed

8297295: Remove ThreadGroup.allowThreadSuspension#11373
AlanBateman wants to merge 3 commits into
openjdk:masterfrom
AlanBateman:JDK-8297295

Conversation

@AlanBateman

@AlanBateman AlanBateman commented Nov 25, 2022 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown
Contributor

Another small step in the multi-release/multi-year effort to remove cruft from Thread/ThreadGroup.

java.lang.ThreadGroup.allowThreadSuspension(boolean) dates from JDK 1.1 and the Classic VM. The method controlled whether threads were suspended when the GC failed. It appears to have interacted with a callback mechanism that could potentially free memory, allowing the GC to retry. The method was never specified .

The method was deprecated and changed to do nothing in JDK 1.2. It was deprecated for removal in Java 14.

A corpus analysis of 30M classes in 130k artifacts found 0 usages of this method.

It is time to finally remove this method. The compatibility impact should be negligible. Joe, Stuart and I discussed briefly and think early in JDK 21 is a good time to do this.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8297295: Remove ThreadGroup.allowThreadSuspension
  • JDK-8297331: Remove ThreadGroup.allowThreadSuspension (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11373/head:pull/11373
$ git checkout pull/11373

Update a local copy of the PR:
$ git checkout pull/11373
$ git pull https://git.openjdk.org/jdk pull/11373/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11373

View PR using the GUI difftool:
$ git pr show -t 11373

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11373.diff

@bridgekeeper

bridgekeeper Bot commented Nov 25, 2022

Copy link
Copy Markdown

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Nov 25, 2022

Copy link
Copy Markdown

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the core-libs core-libs-dev@openjdk.org label Nov 25, 2022
@AlanBateman

AlanBateman commented Nov 25, 2022

Copy link
Copy Markdown
Contributor Author

/csr

@openjdk openjdk Bot added the csr Pull request needs approved CSR before integration label Nov 25, 2022
@openjdk

openjdk Bot commented Nov 25, 2022

Copy link
Copy Markdown

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@AlanBateman please create a CSR request for issue JDK-8297295 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@AlanBateman AlanBateman marked this pull request as ready for review November 28, 2022 11:12
@openjdk openjdk Bot added the rfr Pull request is ready for review label Nov 28, 2022
@mlbridge

mlbridge Bot commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown

Webrevs

@jaikiran

jaikiran commented Nov 28, 2022

Copy link
Copy Markdown
Member

Joe, Stuart and I discussed briefly and think early in JDK 21 is a good time to do this.

I guess, this would then mean this PR will be integrated into mainline after 8th December when the branch for JDK 20 will be forked https://openjdk.org/projects/jdk/20/#Schedule?

jaikiran
jaikiran approved these changes Nov 28, 2022
View reviewed changes

@jaikiran jaikiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@stuart-marks

stuart-marks commented Nov 28, 2022

Copy link
Copy Markdown
Member

@jaikiran wrote:

I guess, this would then mean this PR will be integrated into mainline after 8th December when the branch for JDK 20 will be forked

Yes, I'm sure this will go in soon after the JDK 20 fork.

ChrisHegarty
ChrisHegarty approved these changes Nov 29, 2022
View reviewed changes

@ChrisHegarty ChrisHegarty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jddarcy
jddarcy approved these changes Nov 29, 2022
View reviewed changes

@jddarcy jddarcy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for JDK 21.

@AlanBateman

AlanBateman commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

/csr unneeded
/csr needed

@openjdk openjdk Bot removed the csr Pull request needs approved CSR before integration label Dec 8, 2022
@openjdk

openjdk Bot commented Dec 8, 2022

Copy link
Copy Markdown

@AlanBateman determined that a CSR request is not needed for this pull request.

@openjdk

openjdk Bot commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297295: Remove ThreadGroup.allowThreadSuspension

Reviewed-by: jpai, smarks, chegar, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added ready Pull request is ready to be integrated csr Pull request needs approved CSR before integration labels Dec 8, 2022
@openjdk

openjdk Bot commented Dec 8, 2022

Copy link
Copy Markdown

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@AlanBateman please create a CSR request for issue JDK-8297295 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk openjdk Bot removed ready Pull request is ready to be integrated csr Pull request needs approved CSR before integration labels Dec 8, 2022
@jddarcy

jddarcy commented Dec 8, 2022

Copy link
Copy Markdown
Member

Still looks good.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Dec 8, 2022
@AlanBateman

AlanBateman commented Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk

openjdk Bot commented Dec 8, 2022

Copy link
Copy Markdown

Going to push as commit d35e840.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Dec 8, 2022
@openjdk openjdk Bot closed this Dec 8, 2022
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2022
@openjdk

openjdk Bot commented Dec 8, 2022

Copy link
Copy Markdown

@AlanBateman Pushed as commit d35e840.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JohnNiang JohnNiang mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@jaikiran jaikiran jaikiran approved these changes

@stuart-marks stuart-marks stuart-marks approved these changes

@jddarcy jddarcy jddarcy approved these changes

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlanBateman @jaikiran @stuart-marks @jddarcy @ChrisHegarty