Skip to content

Added /resource/smart_scene API#35

Merged
thibauult merged 1 commit into
openhue:mainfrom
a-stangl:feat/smart-scenes
Aug 7, 2024
Merged

Added /resource/smart_scene API#35
thibauult merged 1 commit into
openhue:mainfrom
a-stangl:feat/smart-scenes

Conversation

@a-stangl

@a-stangl a-stangl commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Added the API endpoints and schemas for "Dynamic Scenes" (aka Smart Scenes).

@a-stangl

a-stangl commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

I haven't seen any schemas where the object properties have been declared required. In case no required properties should be declared, please let me know and I change this.
I guess if validation regarding required properties is needed, it should be done globally and not just for the smart_scene endpoint(s). Therefore, reverting this.

I manually compared the generated Redoc documentation with the one from the Hue CLIP API references (here & here), and I think this should now be ready for review.

@a-stangl a-stangl marked this pull request as ready for review August 6, 2024 15:38
@thibauult

Copy link
Copy Markdown
Collaborator

Hi @a-stangl, thanks a lot for your contribution!

I guess if validation regarding required properties is needed, it should be done globally and not just for the smart_scene endpoint(s). Therefore, reverting this.

Well, I must admit here that I haven´t been cautious with this from the very beginning of the project. I believe it should have been done globally. I am totally fine if you want to re-introduce it.

@thibauult thibauult self-requested a review August 6, 2024 16:54
@thibauult thibauult added the enhancement New feature or request label Aug 6, 2024
@a-stangl

a-stangl commented Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

All right, @thibauult, I added the required properties where it makes sense and where I don't have to change too many global things.

@thibauult thibauult merged commit 66b4f5c into openhue:main Aug 7, 2024
@thibauult

Copy link
Copy Markdown
Collaborator

Thanks again @a-stangl for your contribution 🙏

The Smart Scene API has been published and is now available from the public specification.

@a-stangl a-stangl deleted the feat/smart-scenes branch August 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants