Skip to content

Fix duplicate Dynamics schema#34

Merged
thibauult merged 1 commit into
openhue:mainfrom
a-stangl:fix/duplicate-dynamics-schema
Aug 6, 2024
Merged

Fix duplicate Dynamics schema#34
thibauult merged 1 commit into
openhue:mainfrom
a-stangl:fix/duplicate-dynamics-schema

Conversation

@a-stangl

@a-stangl a-stangl commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Redoc printed a warning regarding a duplicate schema named Dynamics and dynamically adjusted the name (in this case, the name of the "Dynamics" schema of "grouped light" was adjusted) to Dynamics-2.

Renaming the light Dynamics schema to LightDynamics solves this issue.

Note that this is a breaking change in case one uses generated API clients.

Redoc printed a warning regarding a duplicate schema named `Dynamics` and
dynamically adjusted the name (in this case, the name of the "Dynamics" schema
of "grouped light" was adjusted) to `Dynamics-2`.

Renaming the light `Dynamics` schema to `LightDynamics` solves this issue.
@a-stangl

a-stangl commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

Just for the record, this is the error I'm seeing

make build
Building the OpenAPI single-file specification...
bundling /home/andreas/work/personal/openhue-api/src/main.yaml...
[1] src/grouped_light/schemas/GroupedLightPut.yaml:25:5 at #/properties/dynamics

Two schemas are referenced with the same name but different content. Renamed Dynamics to Dynamics-2.

23 |   $ref: '../../common/Signaling.yaml'
24 | dynamics:
25 |   $ref: '../../common/Dynamics.yaml'
26 |

Warning was generated by the bundler rule.

@thibauult thibauult merged commit f7909b1 into openhue:main Aug 6, 2024
@thibauult

Copy link
Copy Markdown
Collaborator

Thanks @a-stangl for fixing this!

@a-stangl a-stangl deleted the fix/duplicate-dynamics-schema branch August 6, 2024 14:58
@thibauult thibauult added the bug Something isn't working label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants