Fix localized dataset processing#746
Merged
toebivankenoebi merged 2 commits intomasterfrom Feb 11, 2026
Merged
Conversation
Undo changes introduced by 3a7c49e: `DontResolveLayers` When deciding if a layer is localized we need to read Layers.
nirvn
reviewed
Feb 11, 2026
b31d0e9 to
9603663
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undo changes introduced by 3a7c49e:
DontResolveLayers.When deciding if a layer is localized we need to read Layers.
There's an issue with the latest qfieldsync release regarding localized datasets:
It's not showing the option to upload shared_datasets in the dialog and therefor it's not creating the shared_datasets project nor uploading any files. I could narrow it down to the
get_localized_dataset_filesfunction:The problem is with the code change in 3a7c49e we don't resolve the layers and they then don't have a dataProvider so we always go out of the loop.
When disabling:
everything seems to work again:
shared_datasetsproject is created and the shared dataset uploaded as well.I'm unsure if we need the layers for
qfieldsync/qfieldsync/gui/cloud_transfer_dialog.py
Line 562 in 72a8a84
I leave that up to @nirvn to decide.