Fix error handling presence of gpkg wal/shm files on the cloud#745
Merged
suricactus merged 1 commit intomasterfrom Feb 12, 2026
Merged
Fix error handling presence of gpkg wal/shm files on the cloud#745suricactus merged 1 commit intomasterfrom
suricactus merged 1 commit intomasterfrom
Conversation
suricactus
approved these changes
Jan 30, 2026
Collaborator
suricactus
left a comment
There was a problem hiding this comment.
Good to merge.
Since you had to decrypt this now, I would suggest to add a few comments on the lines before merging, e.g. why do we continue if -shm or -wal files.
Collaborator
|
I think we better release this sooner than later, I can live without the comments for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@beanzmo stumbled on a silent killer in our QFieldSync code! 😉
The code handling the presence of wal and shm files within a cloud project remote files list was broken. The code referred to an nonexistent self.local_path variable, which crashed the copying process.
If you were lucky and the wal file was the first file, you'd end up with an empty directory indicating something very wrong, But, if it happened halfway, you would end up with a half copied cloud project. This could lead to failure to copy attachments, offline data data.gpkg, etc.