Fix offlining feature intersecting AOI checkbox#723
Merged
Conversation
suricactus
approved these changes
Sep 8, 2025
Collaborator
suricactus
left a comment
There was a problem hiding this comment.
Code looks good to me and happy to publish a patch release with it whenever merged.
Member
Author
|
@suricactus , let's do it ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression from rebase commit here (45333da) whereas the checkbox that dictate whether layers being offlined should only copy features interesting the AOI was renamed to "map theme", and added to the "buttonGroup" group, which led to a broken checkbox state.
@gounux , gentle ping.