Skip to content

Add stricter ruff rules in to the codebase#720

Merged
suricactus merged 67 commits intomasterfrom
apply_stricter_ruff
Sep 1, 2025
Merged

Add stricter ruff rules in to the codebase#720
suricactus merged 67 commits intomasterfrom
apply_stricter_ruff

Conversation

@suricactus
Copy link
Copy Markdown
Collaborator

@suricactus suricactus commented Aug 29, 2025

Continuation of the effort in libqfieldsync. A handful of bugs and potential misbehaves.

Follow-up of #711

@suricactus
refactor: remove outdated utf8 encoding declaration, ruff UP009
9080368
@suricactus
refactor: make comment single line when possible, ruff D200
98b328d
@suricactus
refactor: remove useless inheritance from object, ruff UP004
fef432c
@suricactus
refactor: use short list definition, ruff C408
2c4d31c
@suricactus
refactor: do not call super() with parameters, ruff UP008
5088d06
@suricactus
refactor: multiline docstrings should have the first line empty, ruff…
5c2a957 
… D213
@suricactus
refactor: remove empty lines after a dostring, ruff D202
9d746e6
@suricactus
refactor: no implicit return of None, ruff RET502
9bfa55d
@suricactus
refactor: no NOQA without a code, ruff RUF100
87c4287
@suricactus
ruff: make sure the class names are CamelCase unless when they should…
b0552be 
…n't, ruff N801
@suricactus
refactor: explicitly state the function is used for checksum calculat…
7bfa02e 
…ion, not security, ruff S324
@suricactus
refactor: in PEP8 it is defined that all exception should suffix in `…
28becee 
…Error`, ruff N818
@suricactus
refactor: do not defined unused variable, ruff B007
2271541
@suricactus
refactor: no repeated equality, but check with in operator, ruff P…
4af4e89 
…LR171
@suricactus
refactor: do not use non-snakecase variable names, ruff N816
11ac6c4
@suricactus
fix: actually store the raw reply
18ce1cf
@suricactus
refactor: ignore unused parameters, ruff ARG002
d3c42d0
@suricactus
refactor: add custom QFieldSyncError instead of using the raw `Excep…
19e3280 
…tion` class, ruff TRY002
@suricactus
refactor: make TODOs happy, a little cleanup too, ruff TD002
9f4b397
@suricactus
refactor: remove empty catch blocks, ruff S110
c1b1d2d
@suricactus
refactor: remove pre QGIS 3.15 code
e073f7c
@suricactus
refactor: remove pre QGIS 3.16.1 code
945356f
@suricactus
refactor: remove pre QGIS 3.18 code
b73cd08
@suricactus
refactor: remove pre QGIS 3.20 code
6dd8604
@suricactus
refactor: use Qgis.versionInt() instead of Qgis.QGIS_VERSION_INT
1cb822d
@suricactus
refactor: do not use raw integers, introduce multiple constants. ruff…
0b86397 
… PLR2004
@suricactus
refactor: kill the unused CloudReply class
6b741dc
@suricactus
refactor: kill the unused CloudConverter.progressStopped signal
124acff
@suricactus
refactor: delete the EventEater class that is not used
93054b5
@suricactus
refactor: rename pascalCased methods to snake_case, ruff N802
55db08a
@suricactus
refactor: prefix unused lambda arguments, ruff ARG005
a517bf3
@suricactus
refactor: reraise errors, ruff TRY201
abf4ff0
@suricactus
refactor: remove useless expressions, ruff B018
b38ccf7
@suricactus
refactor: remove useless else when there is if ...: continue, ruf…
944fa6c 
…f RET507
@suricactus
refactor: do not use mutable param defaults, ruff B006
9f51729
@suricactus
refactor: add explicit return None when non-None return might happe…
f11aa8c 
…n, ruff B006
@suricactus
refactor: remove a useless list comprehension, ruff C416
d967c95
@suricactus
refactor: remove useless map, ruff C417
80099b2
@suricactus
refactor: do not use type as attribute or param name, ruff A002
fdbc1c1
@suricactus
refactor: raise assertion error with a message instead of assert 0,…
8018215 
… ruff PT015
@suricactus
refactor: no need to get the keys to check if present in a dict, ruff…
d9e9f6c 
… SIM118
@suricactus
refactor: explicitly say that import is used only in typechecking, ru…
3f20d03 
…ff TC001
@suricactus
refactor: use the more secure tempfile.NamedTemporaryFile, ruff S306
9a31a85
@suricactus
fix: checks for function definitions that use a loop variable, ruff B023
4364270 
The loop variable is not bound in the function definition, so it will always have the value it had in the last iteration when the function is called.
@suricactus
refactor: rewrite map with a list comprehension, ruff C417
72c455d
@suricactus
refactor: mark acceptable some try/except inside loops, ruff PERF203
11b860a
@suricactus
refactor: remove relative imports, ruff TID252
4266b1a
@suricactus
refactor: ignore parts that are unfortunately way too complex, ruff P…
ec3af69 
…LR0912, PLR0915
@suricactus
refactor: empty the __init__ file
e91ddc1
@suricactus
typing: make more None-able arguments to be Optional
a4d0165
@suricactus
feat: add pyproject.toml file to configure ruff and friends
0f02550
@suricactus suricactus force-pushed the apply_stricter_ruff branch from fd2def3 to 0f02550 Compare August 29, 2025 15:54
@suricactus suricactus requested a review from nirvn August 29, 2025 15:55
This was referenced Aug 29, 2025
Open
Merged
@suricactus
Copy link
Copy Markdown
Collaborator Author

suricactus commented Sep 1, 2025

@nirvn would be great if we can get this one merged.

nirvn
nirvn approved these changes Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green all good

@suricactus suricactus merged commit 856d91b into master Sep 1, 2025
7 checks passed
@suricactus suricactus deleted the apply_stricter_ruff branch September 1, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirvn nirvn nirvn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suricactus @nirvn