Merged
Conversation
Member
|
Thanks a lot, can you run to apply the code formatting? |
Contributor
Author
|
Hey this somehow changes a lot (116) of files I haven't touched and code I haven't changed. Are you sure? What exactly does the CI want to get changed? Edit: I patched the files with the diff output from the workflow. Was that all it took to make the code check happy? |
m-kuhn
reviewed
Aug 22, 2025
Member
|
Not sure why it updated that many files, but thanks to these changes it's now clean. |
Collaborator
|
hey, @freeshrugsxd , just wanted to say thank you for being a good OSS citizen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ This PR aims to improve Qt6 support.
Most of it is straightforward find and replace of enums but there are two cases where we don't have a Qt6 equivalent:
QNetworkRequest.FollowRedirectsAttributeis gone and the default redirect behavior changes. I'm not 100% sure but I think this means that we do not need to implicitly set any attribute here and can just delete those lines?QPainter.HighQualityAntialiasingwas already obsolete and ignored in Qt5 and got removed in Qt6AFAICT the plugin works in both Qt5 and Qt6 builds but I am unable to test the cloud related code changes.
Let me know if you need anything more.
Regards