fix: do not use Enum as default value which causes the plugin to fail after reloading#128
Merged
suricactus merged 1 commit intomasterfrom Sep 9, 2025
Merged
fix: do not use Enum as default value which causes the plugin to fail after reloading#128suricactus merged 1 commit intomasterfrom
suricactus merged 1 commit intomasterfrom
Conversation
… after reloading NOTE: while it will be much more readable to pass `export_type` parameter to have a default value of `ExportType.Cable`, we cannot reference an Enum as a default value in a QGIS plugin, as when the file reloaded (e.g. enable/disable the plugin, Plugin reloader), the enum will have a different address and comparisons will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: while it will be much more readable to pass
export_typeparameter to have a default value ofExportType.Cable, we cannot reference an Enum as a default value in a QGIS plugin, as when the file reloaded (e.g. enable/disable the plugin, Plugin reloader), the enum will have a different address and comparisons will fail.